Skip to content

keep all generated files in a cache folder #29

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 6 commits into from
Dec 13, 2022
Merged

keep all generated files in a cache folder #29

merged 6 commits into from
Dec 13, 2022

Conversation

2bndy5
Copy link
Contributor

@2bndy5 2bndy5 commented Dec 13, 2022

resolves #27

@2bndy5
change workflow triggers
6fb9af3 
run on pr sync events

fix upload of codecov report
@codecov-commenter
Copy link

codecov-commenter commented Dec 13, 2022 •
edited
Loading

Codecov Report

Merging #29 (0c7738d) into main (f53976a) will increase coverage by 0.83%.
The diff coverage is 87.34%.

@@            Coverage Diff             @@
##             main      #29      +/-   ##
==========================================
+ Coverage   80.68%   81.51%   +0.83%     
==========================================
  Files           6        8       +2     
  Lines         647      714      +67     
==========================================
+ Hits          522      582      +60     
- Misses        125      132       +7
Impacted Files Coverage Δ
cpp_linter/thread_comments.py 69.44% <ø> (+7.40%) ⬆️
cpp_linter/git.py 78.20% <78.20%> (ø)
cpp_linter/__init__.py 92.85% <92.85%> (+1.05%) ⬆️
cpp_linter/run.py 76.84% <93.18%> (-2.31%) ⬇️
cpp_linter/clang_format_xml.py 100.00% <100.00%> (ø)
cpp_linter/clang_tidy.py 100.00% <100.00%> (ø)
cpp_linter/clang_tidy_yml.py 89.58% <100.00%> (ø)
cpp_linter/cli.py 100.00% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@shenxianpeng shenxianpeng added the enhancement New feature or request label Dec 13, 2022
@2bndy5 2bndy5 merged commit 35e64f8 into main Dec 13, 2022
@2bndy5 2bndy5 deleted the use-cache-folder branch December 13, 2022 10:03
@2bndy5
Copy link
Contributor Author

2bndy5 commented Feb 16, 2023

I just realized this was never released. Was there something blocking it (I don't remember)?

@shenxianpeng
Copy link
Contributor

shenxianpeng commented Feb 18, 2023 •
edited
Loading

I also forget there are new changes in cpp-linter :) The change time is near #24 maybe expect to release it together.
But it should be better and safer to release it separately, the new version will be 1.6.0?

@2bndy5
Copy link
Contributor Author

2bndy5 commented Feb 18, 2023

Yeah, better to release often... (or however the euphemism goes). I publish a patch bump. This change is really only useful for local execution because a CI workspace is discarded when the run finishes, and the file names are designed to be non-conflicting. So, it isn't urgent to update the action requirements for this.

I may not get to #24 any time soon. I'm working on a few other project's simultaneously right now.

@2bndy5
Copy link
Contributor Author

2bndy5 commented Feb 18, 2023

the new version will be 1.6.0?

I was thinking a patch bump because this change is more of an implementation detail, and no users have reported conflict about the generated files in the CI workspace.

@shenxianpeng
Copy link
Contributor

A patch bump makes sense. We can have more time to think about better formats for #24 😃

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shenxianpeng shenxianpeng shenxianpeng approved these changes

Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

use a proper .cpp_linter-cache folder
3 participants
@2bndy5 @codecov-commenter @shenxianpeng