Skip to content

fix format comment #36

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Nov 2, 2023
Merged

fix format comment #36

merged 3 commits into from
Nov 2, 2023

Conversation

2bndy5
Copy link
Contributor

@2bndy5 2bndy5 commented Oct 30, 2023

in reference to cpp-linter/cpp-linter-action#161

May need to adjust unit tests for this

@2bndy5 2bndy5 added the bug Something isn't working label Oct 30, 2023
@codecov
Copy link

codecov bot commented Oct 30, 2023 •
edited
Loading

Codecov Report

Merging #36 (b9c5321) into main (7405a4a) will decrease coverage by 0.12%.
Report is 1 commits behind head on main.
The diff coverage is 100.00%.

❗ Current head b9c5321 differs from pull request most recent head b5644ed. Consider uploading reports for the commit b5644ed to get more accurate results

@@            Coverage Diff             @@
##             main      #36      +/-   ##
==========================================
- Coverage   81.48%   81.37%   -0.12%     
==========================================
  Files           8        8              
  Lines         713      714       +1     
==========================================
  Hits          581      581              
- Misses        132      133       +1
Files Coverage Δ
cpp_linter/run.py 76.62% <100.00%> (+0.07%) ⬆️

... and 1 file with indirect coverage changes

@2bndy5
Copy link
Contributor Author

2bndy5 commented Oct 30, 2023

Code coverage decrease is because we aren't uploading reports for unit tests on Windows. It is not a direct result of these changes. These changes are all covered by current unit tests. I admit, the unit test covering these lines should be more exhaustive to detect the reported bug.

@2bndy5 2bndy5 marked this pull request as ready for review October 30, 2023 20:30
2bndy5
2bndy5 commented Nov 1, 2023
View reviewed changes
@2bndy5 2bndy5 force-pushed the fix-format-comment branch from 7099488 to b9c5321 Compare November 1, 2023 08:06
2bndy5 added 3 commits November 1, 2023 01:14
@2bndy5
fix format comments
172a64c 
- make sure that total count of files that need formatting align with the number of files listed
- respect all values of `lines-changed-only` when creating format comment
@2bndy5
ensure clang v12 is installed
d2720dd 
Ubuntu-latest runners no longer ship with clang v12
@2bndy5
update pre-commit hooks
b5644ed
@2bndy5 2bndy5 force-pushed the fix-format-comment branch from b9c5321 to b5644ed Compare November 1, 2023 08:15
@sonarqubecloud SonarQubeCloud
Copy link

sonarqubecloud bot commented Nov 1, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@2bndy5
Copy link
Contributor Author

2bndy5 commented Nov 1, 2023

I found a more efficient way to get the count of files that need formatting (doesn't use regex pattern anymore).

@2bndy5 2bndy5 merged commit 977eb16 into main Nov 2, 2023
@2bndy5 2bndy5 deleted the fix-format-comment branch November 2, 2023 06:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shenxianpeng shenxianpeng shenxianpeng approved these changes

Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@2bndy5 @shenxianpeng