add more specific outputs #37
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
satisfies feature requested in cpp-linter/cpp-linter-action#168
|
Kudos, SonarCloud Quality Gate passed!
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #37 +/- ##
==========================================
+ Coverage 84.37% 84.50% +0.13%
==========================================
Files 8 8
Lines 691 697 +6
==========================================
+ Hits 583 589 +6
Misses 108 108 ☔ View full report in Codecov by Sentry. |
2bndy5
commented
Dec 2, 2023
Comment on lines
-64
to
+68
| exit_code = override if override is not None else bool(Globals.OUTPUT) | ||
| exit_code = ( | ||
| override | ||
| if override is not None | ||
| else (Globals.format_failed_count + Globals.tidy_failed_count) | ||
| ) |
There was a problem hiding this comment.
Using bool(Globals.OUTPUT) always returns true since revision of comment contents (see changes in #32). So, this enhancement fixes that ambiguity while implementing the new outputs. 🚀
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
satisfies feature requested in cpp-linter/cpp-linter-action#168