resolves #65 #66
Merged
resolves #65 #66
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #66 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 19 19
Lines 1310 1315 +5
=========================================
+ Hits 1310 1315 +5 ☔ View full report in Codecov by Sentry. |
shenxianpeng
approved these changes
Feb 10, 2024
|
It took a while to track down a bug... The test PR review now looks as expected without errors. 🎉 I'm going to run a few more test commits in the test repo... Sadly, this solution was not as simple as foreseen. |
|
LGTM (finally) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This will remove the line "No objections from ..." when it is not relevant in PR review summary comments.
Also adds a 🎉 for approved PR reviews