truncate thread comment to max size allowed #90
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #90 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 20 20
Lines 1392 1392
=========================================
Hits 1392 1392 ☔ View full report in Codecov by Sentry. |
It makes sense.
Can this be solved by truncating characters less than 65535? |
Thread-comments may become malformed because I'm truncating text to only 65535 characters. It would be solved by making the comment twice, once for step-summary (with no length limit) and once for thread-comments (with length limit). But the API isn't currently designed to call |
|
superceded by #91 |
resolves #89
This should avoid the error observed in #89.
A secondary problem
The thread-comments text is the same string used in step-summary text. But step-summary is not limited to a certain number of characters because it is written to a file. Therefore, if I truncate the comment's text when it is created in
make_comment(), then the step-summary text will show the same lack of data, even though it isn't limited to 65535 characters.As an alternative, I've chosen to just truncate the
payload["body"]when posting a thread-comment using the REST API call. However, thread-comments may become malformed markdown syntax if they are longer than 65535 characters.For example:
A very long comment body that exceeds 65535 characters in the next line. </details>could become malformed like so