add codespell to pre-commit hooks #93
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #93 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 20 20
Lines 1392 1437 +45
=========================================
+ Hits 1392 1437 +45 ☔ View full report in Codecov by Sentry. |
Merged
|
I'm going to merge #92 first, then rebase all my branches open in PRs... @shenxianpeng BTW, this codespell pre-commit hook would be nice to use in cpp-linter-action and our other repos. Maybe the pre-commit reusable workflow could add the codespell problem matcher as an extra setup step. PS - I know there is a github action that includes a problem matcher for the codespell project, but it has problems. Most notably, you cannot select what version of codespell it runs. |
also updated pre-commit hooks and ran them
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
also updated pre-commit hooks and ran them