perf: use io.StringIO instead tempdir/tempfile #94
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #94 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 20 20
Lines 1437 1436 -1
=========================================
- Hits 1437 1436 -1 ☔ View full report in Codecov by Sentry. |
2bndy5
requested changes
Mar 26, 2024
|
Initial benchmark indeed looks a bit faster: The previous PR averaged about 1.95 times faster with |
2bndy5
approved these changes
Mar 26, 2024
Its good that this was done in a separate PR. If we do get problems with memory saturation, then we can simply revert the merge commit and rollback to the temp file approach. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a follow-up PR of #92.
In the previous PR review #92 (comment) @2bndy5 suggested:
In that version, multiprocessing.Pool.imap() was used for parallel processing, and it blocks until all of the results are made available (if I'm not misunderstood). The behavior might cause memory problems on repositories with many files and warnings.
After, I decided to switch to the async version in 4e029a3 by using concurrent.futures.as_completed, which returns the logs as each work is completed (hence its name). Now that the logs are immediately printed after the subprocess is done processing a file and logs for a single file would not overflow memory in most projects, I think it is safe to use
io.StringIOfor better performance (as with the original suggestion).