use native package managers for linux runner #116
Conversation
There was a problem hiding this comment.
Thanks for researching this more (and doing the implementation in action.yml). I agree other OS support is spotty for package managers, but that's because the ones available aren't actually shipped with the OS (aka non-native).
The only edge case I can think of with this change is if the version specified isn't available in the updated PPAs that apt-get update fetches. For example, LLVM may release v16, but the PPA may not immediately provide v16... I'm confident we could cross that bridge if we need to in the future though.
|
Oops, it looks like ubuntu 20.04 runner doesn't have v13 or v14 in the PPA. I think ubuntu 22.04 will have these, but that hasn't been made the default ( |
|
Yes. v13 or v14 not in ubuntu 20.04 yet : ( |
|
they will be soon though... actions/runner-images#6399 |
|
cool, subscribed to that issue. I'd like to release this change now (or may also support v13 and v14 by adding new repo like I did here if needed.) |
|
yeah, I'm ok with moving forward on this. |
|
Based on https://semver.org/, I guess we might treat this change as a feature, so the version will be v2.2.0, not v2.1.5. any thoughts about versioning |
|
that sounds right. |
Fix #106
Right now this only supports Linux runner
Why do not support macOS and windows runner because the following reasons:
on macOS, brew only supports a few versions of clang-format and does not support clang-tidy right now
on windows chocolatey support installing both clang-format and clang-tidy but the version is different with user input. for example when the user input
13in the cpp-linter.yml etc, we need to match this version from13to13.0.1otherwise can not find and install clang 13 on windows. we also need to match for other versions if we support them, but it would be best to do it like in a setup-action.sh script file. right now I think it should be enough we only support linux.