Skip to content

Test thread comment input update #22

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 28 commits into from
Closed

Test thread comment input update #22

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
28 commits
Select commit Hold shift + click to select a range
de41419
try update comments
2bndy5 Oct 24, 2023
26c2bfc
enable lgtm comments
2bndy5 Oct 24, 2023
b0c4f16
enable thread-comments for clang v13
2bndy5 Oct 24, 2023
5ac7565
trigger workflow on push
2bndy5 Oct 26, 2023
c15acbb
trigger CI on PR event
2bndy5 Oct 27, 2023
9aa0039
only check files changed
2bndy5 Oct 27, 2023
83adc1a
don't update comments (create anew instead)
2bndy5 Oct 27, 2023
c99d7ce
check all src files
2bndy5 Oct 27, 2023
6a62e4d
no-lgtm w/ files changed only
2bndy5 Oct 27, 2023
00a60ce
check all files
2bndy5 Oct 27, 2023
f58cdd9
update comment w/ no-lgtm=true; only files changed
2bndy5 Oct 28, 2023
9308fdf
all files; no-lgtm; anew comment
2bndy5 Nov 9, 2023
85bb7f1
only changed files; no-lgtm; anew comment
2bndy5 Nov 9, 2023
98251eb
all files; no-lgtm; update comment
2bndy5 Nov 9, 2023
047d1d4
only files changed; no-lgtm; update comment
2bndy5 Nov 9, 2023
6243a9a
files changed only; yes-lgtm; update comment
2bndy5 Nov 9, 2023
7d454b1
all files; yes-lgtm; update-comment
2bndy5 Nov 9, 2023
cdb6418
only changed files; yes-lgtm; anew comment
2bndy5 Nov 9, 2023
8b0c1a0
TESTING DEPENDABOT BRANCH
2bndy5 Nov 10, 2023
152813f
only post comments from linux runner
2bndy5 Nov 10, 2023
3915a4c
update comment; yes-lgtm; only changed files
2bndy5 Nov 10, 2023
8608d6e
all files; yes-lgtm; update comment
2bndy5 Nov 10, 2023
519286d
all files; anew comment; yes-lgtm
2bndy5 Nov 10, 2023
267db07
changed files; anew comment; yes-lgtm
2bndy5 Nov 10, 2023
dd0980e
changed files; anew comment; no-lgtm
2bndy5 Nov 11, 2023
dd02409
all files; update comment; no-lgtm
2bndy5 Nov 11, 2023
f5ff2f2
changed files; update comment; yes-lgtm
2bndy5 Nov 11, 2023
cd910f0
changed files; update comment; no-lgtm
2bndy5 Nov 11, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 5 additions & 3 deletions .github/workflows/cpp-lint-action.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,7 @@ name: cpp-linter as action
on:
workflow_dispatch:
workflow_call:
pull_request:


jobs:
Expand Down Expand Up @@ -31,21 +32,22 @@ jobs:
run: mkdir build && cmake -Bbuild src

- name: Run linter as action
uses: cpp-linter/cpp-linter-action@latest
uses: cpp-linter/cpp-linter-action@dependabot/pip/cpp-linter-1.6.1
id: linter
env:
GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
with:
style: file
files-changed-only: false
files-changed-only: true
# to ignore all build folder contents
ignore: build
database: build
verbosity: 9
version: ${{ matrix.clang-version }}
thread-comments: ${{ matrix.clang-version == '12' }}
thread-comments: ${{ matrix.os == 'ubuntu-latest' && matrix.clang-version == '12' && 'update' }}
file-annotations: ${{ matrix.clang-version == '12' }}
extra-args: -std=c++14 -Wall
no-lgtm: true

- name: Fail fast?!
# if: steps.linter.outputs.checks-failed > 0
Expand Down
9 changes: 5 additions & 4 deletions .github/workflows/cpp-lint-package.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,7 @@ jobs:
matrix:
clang-version: ['7', '8', '9','10', '11', '12', '13', '14']
repo: ['cpp-linter/cpp-linter']
branch: ['${{ inputs.branch }}']
branch: ['resolve-34'] # ['${{ inputs.branch }}']
fail-fast: false

steps:
Expand Down Expand Up @@ -59,11 +59,12 @@ jobs:
-v=9
-i=build
-p=build
-V=${{ runner.temp }}/llvm
-f=false
-V=${{ runner.temp }}/llvm
-f=true
--extra-arg="-std=c++14 -Wall"
--thread-comments=${{ matrix.clang-version == '12' }}
--thread-comments=${{ matrix.clang-version == '12' && 'true' || 'false' }}
-a=${{ matrix.clang-version == '12' }}
--no-lgtm=false

- name: Fail fast?!
if: steps.linter.outputs.checks-failed > 0
Expand Down