Skip to content

uri fails to parse compact ipv6 representation #146

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Sep 24, 2012
Merged

uri fails to parse compact ipv6 representation #146

merged 1 commit into from
Sep 24, 2012

Conversation

kvikas
Copy link

@kvikas kvikas commented Sep 24, 2012

  1. Hangs on ::1. The rule that matches anything before '::' should match
    0 or 1 occurance.
  2. qi::repeat(min, max) is greedy in nature. Workaround to use
    qi::repeat(n) multiple times with varying n.

@kvikas
uri fails to parse compact ipv6 representation
ffaa80e 
1. Hangs on ::1. The rule that matches anything before '::' should match
   0 or 1 occurance.
2. qi::repeat(min, max) is greedy in nature. Workaround to use
   qi::repeat(n) multiple times with varying n.
@kvikas kvikas mentioned this pull request Sep 24, 2012
Closed
@ghost ghost assigned glynos Sep 24, 2012
@deanberris
Copy link
Member

Wow, that's a little excessive. Do you have numbers on how this affects build times? I can merge this as Glyn is on vacation, but it would be good to have an idea on how this adversely affects build times.

deanberris added a commit that referenced this pull request Sep 24, 2012
@deanberris
Merge pull request #146 from kvikas/master
c1b2102 
uri fails to parse compact ipv6 representation
@deanberris deanberris merged commit c1b2102 into cpp-netlib:master Sep 24, 2012
@kvikas
Copy link
Author

kvikas commented Sep 24, 2012

I'm not sure if these numbers will be representative, I just timed the build pre and post change. Here are the numbers:

After change:
Complete build: gmake 358.29s user 20.82s system 86% cpu 7:17.20 total
Only uri.ipp changed: gmake 45.92s user 4.11s system 89% cpu 55.756 total

Before:
Complete build: gmake 377.06s user 21.04s system 96% cpu 6:54.00 total
Only uri.ipp changed: gmake 44.81s user 4.27s system 91% cpu 53.544 total

@deanberris
Copy link
Member

Looks like this isn't too much of a problem as I had originally thought.
I've merged it anyway, so that should show up nicely on the master branch.

Thanks Vikas!

On Mon, Sep 24, 2012 at 6:58 PM, Vikas Kumar notifications@github.comwrote:

I'm not sure if these numbers will be representative, I just timed the
build pre and post change. Here are the numbers:

After change:
Complete build: gmake 358.29s user 20.82s system 86% cpu 7:17.20 total
Only uri.ipp changed: gmake 45.92s user 4.11s system 89% cpu 55.756 total

Before:
Complete build: gmake 377.06s user 21.04s system 96% cpu 6:54.00 total
Only uri.ipp changed: gmake 44.81s user 4.27s system 91% cpu 53.544 total

—
Reply to this email directly or view it on GitHubhttps://github.com//pull/146#issuecomment-8811110.

Dean Michael Berris | Software Engineer
Google

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@glynos glynos

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@kvikas @deanberris @glynos