-
Notifications
You must be signed in to change notification settings - Fork 425
Make it possible to build cpp-netlib using Boost.Build. #155
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
- Include '*~' pattern into .gitignore - Build libraries in accordance with CMake script - Build tests in accordance with CMake script
|
||
install headers : client server | ||
: <location>../../../boost/network/include/http ; | ||
|
||
install libraries : cppnetlib-uri cppnetlib-server-parsers cppnetlib-client-connections ; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There are a few libraries that need to be built/installed as the header-only option is no longer supported. You may want to keep the others in here?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, I miss this. I will check CMake scripts in order to understand what is needed to be installed. However, could you please provide a real example of list of libraries which are needed to be provided for the end-user? For example, is it interesting to have cppnetlib-utils-thread_pool library to be installed?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A look at the CMake libraries would be good. If you can keep this in sync with the CMake stuff that would be better IMO.
Also, yes, cppnetlib-utils-thread_pool is required for the HTTP Server implementation (for the async server).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I guess, all needed libraries should install now. Please, take a look at commit below
Thanks for this! Can you have a look at my other comment? It seems you're not installing the client/server static libs. |
Any update on this? |
Unfortunately, I had have no time to look at this. I plan to do this later this week. |
Looks good to me, thanks! |
Make it possible to build cpp-netlib using Boost.Build.
Hello
I would like cpp-netlib has an ability to be built by BJam, because I am not able to build it with CMake (due to old version of CMake in my env.)
Please, take a look at changed build scripts.