Skip to content

Here's my attempt at properly handling the content length header #164

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Oct 31, 2012
Merged

Here's my attempt at properly handling the content length header #164

Changes from 1 commit
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
d00836d
Take content length into account when reading body
joelreymont Oct 30, 2012
78afee4
Qualify stoi and only catch exceptions thrown by it.
joelreymont Oct 31, 2012
a941fb1
Use optional member variable to keep track of content length.
joelreymont Oct 31, 2012
3079bda
Use size_t to store content length.
joelreymont Oct 31, 2012
4054936
Print a debug message if content length conversion to size_t fails.
joelreymont Oct 31, 2012
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Qualify stoi and only catch exceptions thrown by it.
  • Loading branch information
@joelreymont
joelreymont committed Oct 31, 2012
commit 78afee4adb9f3f70372a3a118851485b582b3bc2
8 changes: 4 additions & 4 deletions include/network/protocol/http/client/connection/async_normal.ipp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -439,11 +439,11 @@ struct http_async_connection_pimpl : boost::enable_shared_from_this<http_async_c
auto it = headers_.find("Content-Length");
if (it != headers_.end()) {
try {
unsigned content_length = stoi(it->second);
unsigned content_length = std::stoi(it->second);
get_more = (end - begin) < content_length;
NETWORK_MESSAGE("Content-Length: " << content_length
<< ", disconnect: " << !get_more);
} catch(...) {
NETWORK_MESSAGE("Content-Length: " << content_length);
} catch(const std::invalid_argument&) {
} catch(const std::out_of_range&) {
}
}
// Here we don't have a body callback. Let's
Expand Down