Skip to content

Logging improvements: options & custom log record handling #167

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 17 commits into from
Nov 16, 2012
Merged

Logging improvements: options & custom log record handling #167

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
17 commits
Select commit Hold shift + click to select a range
d224a03
Added options to enable logging in non-debug or totally disable logging.
Klaim Nov 12, 2012
e214cf6
Added logging library.
Klaim Nov 12, 2012
fe870cb
Fixed indentation.
Klaim Nov 15, 2012
47e8f86
Added missing copyright informations (klaim)
Klaim Nov 15, 2012
44297c6
Replaced logging handler mutex by shared pointers.
Klaim Nov 15, 2012
69b6499
Using universal references in logging templates.
Klaim Nov 15, 2012
f6e6ee6
Some file cleaning - sorry
Klaim Nov 15, 2012
98a3100
Improved log record.
Klaim Nov 15, 2012
5bd2f7b
Fixed indentation.
Klaim Nov 15, 2012
8452e5c
Added logging test projects (no code yet)
Klaim Nov 15, 2012
4510497
Implemented basic log_record tests (and fixes)
Klaim Nov 15, 2012
f89c2f2
Implemented custom log handler tests.
Klaim Nov 15, 2012
6b9c321
Fixed indentation.
Klaim Nov 15, 2012
8e63590
Merge branch 'master' of https://github.com/cpp-netlib/cpp-netlib
Klaim Nov 15, 2012
892c4c5
Gathered and prefixed all CMake options.
Klaim Nov 15, 2012
084c8fa
Moved down one line as requested.
Klaim Nov 15, 2012
4157a27
Fixed typo in comment.
Klaim Nov 15, 2012
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Fixed indentation.
  • Loading branch information
@Klaim
Klaim committed Nov 15, 2012
commit 5bd2f7b814afc3824c17900e2003dfeb25cb9a32
8 changes: 4 additions & 4 deletions include/network/logging/logging.hpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -34,16 +34,16 @@ class log_record
// Implicit construction from anything serializable to text.
template< typename TypeOfSomething >
log_record( TypeOfSomething&& message )
: m_filename( "unknown" )
, m_line(0)
: m_filename( "unknown" )
, m_line(0)
{
write( std::forward<TypeOfSomething>(message) );
}

// Construction with recording context informations.
log_record( std::string filename, unsigned long line )
: m_filename( filename )
, m_line( line )
: m_filename( filename )
, m_line( line )
{
}

Expand Down
6 changes: 3 additions & 3 deletions libs/network/src/logging/logging.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,9 +18,9 @@ namespace handler
namespace
{
void std_log_handler( const log_record& log )
{
{
std::cerr << "[network " << log.filename() << ":" << log.line() << "] "
<< log.message() << std::endl;
<< log.message() << std::endl;
}
}

Expand All @@ -47,7 +47,7 @@ void log( const log_record& log )
auto log_handler = current_log_record_handler;
if( log_handler )
{
(*log_handler)( log );
(*log_handler)( log );
}
}

Expand Down