Skip to content

Conversation

glynos
Copy link
Member

@glynos glynos commented Dec 26, 2012

Dean,

I've limited this pull request to only a small number of commits for now. The changes I've made are simply:

  • Moved the uri, message and logging 'subprojects' to separate subdirectories, including source code and tests
  • No C++ code has changed
  • Updated all relevant CMakeLists.txt files so that they use the new path references
  • Verified that all tests compile and run on MSVC 2012 and GCC 4.7.2

There are still test failures, but these are the same failures as were there before. Since this is only a restructuring pull request, I'll defer the fixing of this code until afterwards.

The changes to the CMakeLists.txt files are not very clean, just enough to get everything building again.

Still to do:

  • Determine where to put 'version.hpp'
  • Restructure the 'constants' subproject (it seems that the constants defined in these files are limited to HTTP, so can be part of the HTTP library)
  • Remove the 'utils' subdirectory and create a "concurrency" subproject for the thread pool code.
  • Create subdirectories for the HTTP client / server

After this is done, I'd like to:

  • Replace the URI subdirectory with a Git submodule, using the code I've been developing for the last 2 months
  • This will require more sophisticated CMake scripts to make sure that all dependent code can use CMake variables
  • Add google-test and google-mock

Then, start writing new code again :)

@deanberris
Copy link
Member

Awesome stuff, thanks Glyn I'll take your word for it. :)

deanberris added a commit that referenced this pull request Dec 27, 2012
@deanberris deanberris merged commit 9d03a03 into cpp-netlib:master Dec 27, 2012
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants