Another fix for #358: async thr wait in basic_client_facade dtor #405
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -37,6 +37,10 @@ struct basic_client_facade { | |||
| init_pimpl(options); | |||
| } | |||
|
|
|||
| virtual ~basic_client_facade() { | |||
There was a problem hiding this comment.
Why does this need to be virtual?
There was a problem hiding this comment.
OK, it's not needed in this case. It's just my habit. I'll remove it.
|
LGTM -- thanks @leecoder, I'm merging now. |
deanberris
added a commit
that referenced
this pull request
Jun 25, 2014
Another fix for #358: async thr wait in basic_client_facade dtor
leecoder
pushed a commit
to leecoder/cpp-netlib
that referenced
this pull request
Apr 14, 2015
Another fix for cpp-netlib#358: async thr wait in basic_client_facade dtor
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Sometimes, it has crashed in my tc after #402.
*** glibc detected *** ./TestHttp: double free or corruption (out): 0x00007fe760001f70 ***
It's maybe a race condition.
So, I've rewritten by async thr wait in basic_client_facade dtor.
It perfectly works as following http_temp_client_get_test.