Fix for issue #536 "hello_world_client can't commuicate with the hell… #579
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…o_world_async_server_with_work_queue"
|
LGTM Good catch, thanks @gns333! |
deanberris
added a commit
that referenced
this pull request
Jan 5, 2016
Fix for issue #536 "hello_world_client can't commuicate with the hell…
|
@glynos We probably should merge this into master too... |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The async server has to set headers in the handler, otherwise the client will throw " Invalid Version Part". Add HTTP version/status field even if don‘t call set_headers.