Skip to content

Request sni hostname #787

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Nov 2, 2017
Merged

Request sni hostname #787

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
e5e613d
Ability to set a sni_hostname at the request level
maingoh Oct 19, 2017
336fa62
Better test
maingoh Oct 19, 2017
70ea80e
Test only if https enabled
maingoh Oct 19, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Test only if https enabled
  • Loading branch information
@maingoh
maingoh committed Oct 19, 2017
commit 70ea80eaa92df1c772e510a03f923bf63e84f324
44 changes: 20 additions & 24 deletions libs/network/test/http/client_get_test.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -46,30 +46,6 @@ TYPED_TEST(HTTPClientTest, GetHTTPSTest) {
}
}

#endif

TYPED_TEST(HTTPClientTest, TemporaryClientObjectTest) {
using client = TypeParam;
typename client::request request("http://cpp-netlib.org/");
typename client::response response;
ASSERT_NO_THROW(response = client().get(request));
auto range = headers(response);
ASSERT_TRUE(!boost::empty(range));
try {
auto data = body(response);
std::cout << data;
} catch (...) {
FAIL() << "Caught exception while retrieving body from GET request";
}
EXPECT_EQ("HTTP/1.", response.version().substr(0, 7));
EXPECT_TRUE(response.status() == 200u ||
(response.status() >= 300 && response.status() < 400));
}


typedef boost::network::http::basic_client<boost::network::http::tags::http_async_8bit_tcp_resolve, 1, 1> async_client;
#define EXC_PTR(cmd) try { cmd } catch (const std::exception_ptr& ex) { std::rethrow_exception(ex); }

TYPED_TEST(HTTPClientTest, GetRequestSNI) {
using client = TypeParam;
// need sni_hostname to be set
Expand All @@ -94,3 +70,23 @@ TYPED_TEST(HTTPClientTest, GetRequestSNI) {
}

}

#endif

TYPED_TEST(HTTPClientTest, TemporaryClientObjectTest) {
using client = TypeParam;
typename client::request request("http://cpp-netlib.org/");
typename client::response response;
ASSERT_NO_THROW(response = client().get(request));
auto range = headers(response);
ASSERT_TRUE(!boost::empty(range));
try {
auto data = body(response);
std::cout << data;
} catch (...) {
FAIL() << "Caught exception while retrieving body from GET request";
}
EXPECT_EQ("HTTP/1.", response.version().substr(0, 7));
EXPECT_TRUE(response.status() == 200u ||
(response.status() >= 300 && response.status() < 400));
}