-
Notifications
You must be signed in to change notification settings - Fork 534
Empty expression warnings fixed #1215
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
I'm a bit about the while (0) causing a "always false" warning. Why wouldn't it? |
I don't hope so. The Do you have some specific platforms in mind? |
Not really, just a worry. But let's proceed with this. |
This did break pretty much all my training examples. Now I have to add semi-colons to CHECK, LONGS_EQUAL, FAIL usages. I wonder how many more people will have their code broken. |
Do you write different code in your trainings than in the book, articles and papers? 😕 |
I do, and often guiding clients. With a closer look, it's not all my training examples. I was somewhat inconsistent with semi-colons on checks. I've fixed them. Now its consistent, which is good too. The book code was consistent to start with :-) |
We might want to warn the mailing list. Was the mailing list warned? I could not find it quickly. I would have been really surprised if I did not remember this thread on github. |
There is a mailing list? 😲 Maybe this is a good chance to create eg. a 3.9 release to indicate some kind of API differences? |
I'll warn the cpputest google group for starters. |
Empty expression warnings fixed (#1206).
Together with #1205 this concludes the Clang 8 support.