Skip to content

fix(tesseract): Dimnesions with granularity in group_by + drivers support #9928

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 10 commits into from
Aug 29, 2025
Merged

fix(tesseract): Dimnesions with granularity in group_by + drivers support #9928

merged 10 commits into from
Aug 29, 2025

Conversation

waralexrom
Copy link
Member

Check List

  • Tests have been run in packages where changes made if available
  • Linter has been run for changed code
  • Tests for the changes have been added if not covered yet
  • Docs have been added / updated if required

@waralexrom waralexrom requested a review from a team as a code owner August 29, 2025 10:06
@codecov Codecov
Copy link

codecov bot commented Aug 29, 2025 •
edited
Loading

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 84.61%. Comparing base (61f15ab) to head (bc0704e).
⚠️ Report is 3 commits behind head on master.

Additional details and impacted files 
@@           Coverage Diff           @@
##           master    #9928   +/-   ##
=======================================
  Coverage   84.60%   84.61%           
=======================================
  Files         253      253           
  Lines       89874    89874           
=======================================
+ Hits        76038    76046    +8     
+ Misses      13836    13828    -8
Flag Coverage Δ
cubesql 84.61% <ø> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@waralexrom waralexrom requested a review from a team as a code owner August 29, 2025 15:30
KSDaemon
KSDaemon approved these changes Aug 29, 2025
View reviewed changes
Copy link
Member

@KSDaemon KSDaemon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍🏻 LGTM!

@waralexrom waralexrom merged commit 6b582f6 into master Aug 29, 2025
119 of 120 checks passed
@waralexrom waralexrom deleted the tesseract-fixes-and-drivers-support branch August 29, 2025 18:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@paveltiunov paveltiunov paveltiunov approved these changes

@KSDaemon KSDaemon KSDaemon approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@waralexrom @paveltiunov @KSDaemon