feat(ItemBase): loading state #760
Conversation
🦋 Changeset detectedLatest commit: 2e8fe83 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
📦 NPM canary releaseDeployed canary version 0.0.0-canary-dd5a11a. |
🏋️ Size limit report
Click here if you want to find out what is changed in this build |
There was a problem hiding this comment.
Pull Request Overview
This PR adds loading state functionality to the ItemBase component and ItemButton, while also updating Storybook imports across the codebase. The loading feature allows components to display a loading icon in various slots while automatically disabling interaction.
- Added
isLoadingandloadingSlotprops to ItemBase for flexible loading state management - Updated ItemButton to use the new
htmlTypeprop instead of the deprecatedbuttonType - Migrated all Storybook imports from framework-specific packages to the unified
@storybook/reactand@storybook/testpackages
Reviewed Changes
Copilot reviewed 62 out of 63 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
| src/components/content/ItemBase/ItemBase.tsx | Added loading state props and logic with auto slot selection |
| src/components/actions/ItemButton/ItemButton.tsx | Updated to use htmlType prop and support loading state |
| src/components/fields/Select/Select.tsx | Updated button prop from buttonType to htmlType |
| Multiple .stories.tsx files | Migrated Storybook imports to unified packages |
| package.json | Added @storybook/react and @storybook/test dependencies |
Files not reviewed (1)
- pnpm-lock.yaml: Language not supported
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
You can also share your feedback on Copilot code review for a chance to win a $100 gift card. Take the survey.
🧪 Storybook is successfully deployed!
|
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
No description provided.