Skip to content

Conversation

rob-b
Copy link
Contributor

@rob-b rob-b commented Apr 27, 2018

Issue reference:

Submission Checklist:

  • Have you followed the guidelines in our Contributing document (for example, is your tree a clean merge)?
  • Have you checked to ensure there aren't other open Pull Requests for the same update/change?
  • Does your submission build?
  • Does your submission pass tests?
  • Have you run lints on your code locally prior to submission?
  • Have you updated all of the cabal/nix infrastructure?
  • Is this a breaking change? Have you discussed this?

The contributing doc 404s when I clicked it.

https://github.com/onrock-eng/github-webhooks/CONTRIBUTING.md

This is an extension of @TomMD's work in #14 that should pass CI sincestack --test ghci pretty pretty-show github-webhooks aeson bytestring works for me locally

@rob-b rob-b force-pushed the TomMD-feature/head_and_base branch 4 times, most recently from 1bf3e81 to 6931b95 Compare April 27, 2018 11:55
@rob-b rob-b force-pushed the TomMD-feature/head_and_base branch from 6931b95 to 01816d4 Compare April 27, 2018 13:11
@kvanbere
Copy link
Member

kvanbere commented Apr 27, 2018

Hey! Thanks for the pull request.

pullRequestReviewEventFixture has changed for non-related changeset, perhaps by accident?

Edit: resolved via rebase, thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants