chore: fix results formatting for missing totalDuration #1368
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Verification"Duration" is still correctly displayed when it is available:
Normally "Duration" should always be available, so the corrected code only comes into play if there is an error elsewhere. |
I will start to add some built-in linting to the repo as the next step. I would not have caught this without ESLint! |
|
🎉 This PR is included in version 6.7.13 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
Offline linting shows a violation of the ESLint rule no-constant-binary-expression for
github-action/index.js
Line 902 in 8c73325
If
testResults.totalDurationis undefined, then``${testResults.totalDuration / 1000}s
|| ''produces
NaNsnot an empty string.Change
If
testResults.totalDurationis undefined, then fallback to default of displaying0s.