Skip to content

docs: rework command-prefix readme section #1451

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 1, 2025

Conversation

MikeMcC399
Copy link
Collaborator

Situation

The command-prefix parameter

  • refers to the default test command without explaining what the term means
  • does not explain that when used it will convert action parameters into CLI parameters and not invoke the Cypress Module API
  • does not mention that it cannot be used with the custom test command parameter

The example refers to npm whereas the action uses npx.

  • npx restricts the use of this parameter to package manager setups using node_modules

Change

Explain how the action builds the cli command

npx <command-prefix> cypress run <options>

Say how this is compatible with package managers using a node_modules directory compatible with npm.

Change the Percy link to the re-branded BrowserStack Percy link https://www.browserstack.com/docs/percy/integrate/cypress

Note

There is no live example using command-prefix. To use percy would require a token to be available and this is not a desirable prerequisite for users forking the repo and expecting all examples to run as-is.

@MikeMcC399 MikeMcC399 added the documentation Improvements or additions to documentation label May 1, 2025
@MikeMcC399 MikeMcC399 self-assigned this May 1, 2025
@cypress-app-bot
Copy link

@MikeMcC399

This comment was marked as outdated.

@MikeMcC399 MikeMcC399 marked this pull request as ready for review May 1, 2025 14:45
Copy link
Member

@jennifer-shehane jennifer-shehane left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is really helpful, thanks!

@jennifer-shehane jennifer-shehane merged commit 7889d8d into cypress-io:master May 1, 2025
75 checks passed
@MikeMcC399
Copy link
Collaborator Author

@jennifer-shehane

This is really helpful, thanks!

I only looked at it because of the work I'm doing on the command parameter, and it turns out that the original description for command-prefix was never updated and has been inaccurate for quite some time. It's a bit of an anomaly, but it's still in use, so I guess we have to leave it in place.

@MikeMcC399 MikeMcC399 deleted the docs/command-prefix branch May 1, 2025 16:01
Copy link

github-actions bot commented May 1, 2025

🎉 This PR is included in version 6.9.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation released
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants