WIP: Support npm workspaces #382
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
8e5678a to
4c488bc
Compare
Closed
Closed
4c488bc to
a5c20af
Compare
|
I think in the case of npm workspaces, the best option may be for users to manage the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #377
First commit is failing test:
https://github.com/penx/github-action/runs/2709565787?check_suite_focus=true
Second commit is a proposed fix but currently errors with:
This seems to be because it's trying to run
npm cifrom within a workspace subfolder, and unlike the yarn equivalent, npm doesn't like that.