Skip to content

Fix pango library wrong include path (hb.h: No such file or directory) #589

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 7 commits into from
Feb 14, 2021
Merged

Fix pango library wrong include path (hb.h: No such file or directory) #589

merged 7 commits into from
Feb 14, 2021

Conversation

mcejp
Copy link
Contributor

@mcejp mcejp commented Oct 26, 2020

No description provided.

@mcejp
Copy link
Contributor Author

mcejp commented Oct 26, 2020

By the way, on Fedora there is another problem due to warnings triggered by some GTK headers and -Werror being set by tools/build.py, for example:

/usr/include/gtk-2.0/gtk/gtktypeutils.h:236:64: error: ‘GTypeDebugFlags’ is deprecated [-Werror=deprecated-declarations]
  236 | void            gtk_type_init   (GTypeDebugFlags    debug_flags);
      |                                                                ^
In file included from /usr/include/glib-2.0/gobject/gobject.h:24,
                 from /usr/include/glib-2.0/gobject/gbinding.h:29,
                 from /usr/include/glib-2.0/glib-object.h:22,
                 from /usr/include/glib-2.0/gio/gioenums.h:28,
                 from /usr/include/glib-2.0/gio/giotypes.h:28,
                 from /usr/include/glib-2.0/gio/gio.h:26,
                 from /usr/include/gtk-2.0/gdk/gdkapplaunchcontext.h:30,
                 from /usr/include/gtk-2.0/gdk/gdk.h:32,
                 from /usr/include/gtk-2.0/gtk/gtk.h:32,
                 from dialog_handler_gtk.h:12,
                 from dialog_handler.h:11,
                 from client_handler.h:14,
                 from client_handler.cpp:9:

@cztomczak
Copy link
Owner

Why is harfbuzz required?
So this still doesn't work on Fedora. What version of GTK did you install? Try a newer version.

@mcejp
Copy link
Contributor Author

mcejp commented Oct 31, 2020

hb.h is included by some random GTK header. I suppose that if the Makefiles had used pkg-config instead of hardcoded paths, this problem would not arise.

My version of gtk2-devel is 2.24.32 and glib2-devel is 2.64.6.

@cztomczak
Copy link
Owner

cztomczak commented Feb 14, 2021 •
edited
Loading

This is an issue with Pango library having wrong include path: https://gitlab.gnome.org/GNOME/pango/-/issues/387
Doesn't look like Fedora specific issue.

@cztomczak cztomczak changed the title Fix Fedora 32 build error (hb.h: No such file or directory) Fix pango library wrong include path (hb.h: No such file or directory) Feb 14, 2021
@cztomczak cztomczak merged commit 96f3b5e into cztomczak:master Feb 14, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mcejp @cztomczak