Add support for Python 3.8 and Upgrade Cython #594
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes: #546 Had to include harfbuzz manually as newer Pango change this. See: eiskaltdcpp/eiskaltdcpp#413 https://gitlab.gnome.org/GNOME/pango/-/issues/387 Also had to add `-Wno-deprecated-declarations` to get this to compile because of the following errors that didn't seem to be coming from this code directly: warning: ‘GTimeVal’ is deprecated: Use 'GDateTime' instead warning: ‘GTypeDebugFlags’ is deprecated
|
What code was causing these warnings? |
|
As far as I could tell its an interaction between gtk and glib. I'm building on Ubuntu 18.04. |
|
Have you tested Windows and Mac as well? |
|
I don't have access to a Windows or Mac computer unfortunately. |
|
There been any news on this PR? Python 3.8 support is critical for our application currently. |
|
I don't have the ability to test this PR on windows or mac. if anyone does I'm sure the author would appreciate that and it would help get this merged. |
|
I can test this on Windows, but may take a while as I have other priorities. I expect to be able to test this by 27th nov, if noone beats me to it. |
|
Seems to work fine on windows. As I no longer have VS2017 I made a little edit to make it VS2019, the examples and our application run fine on windows. |
|
Got this working on Windows recently but I needed to make some tweaks. |
|
Works for me on Ubuntu 20.10. |
|
I'm looking to add compatibility for python 3.8 or even 3.9 on linux. I just saw that this merge request added 3.8 compatibility for linux, but then the commit right after it removed it. (d6deaf8#diff-b335630551682c19a781afebcf4d07bf978fb1f8ac04c6bf87428ed5106870f5L214) – but why? Reading this thread sounds to me like it was tested under linux. What possible issues would i need to solve to add 3.8 compatibility for linux? |
|
@gmjosack maybe you know the answer to this? |
|
Sorry, I don't have any context on that commit but also don't really see anything in it that would imply linux support would have been removed. Is it just a documantation bug? I'm not currently using cefpython so can't provide any support there. |
|
Well, the next release following it (66.1) made it clear that linux is not supported and put it on the roadmap (if enough people pay for it, i guess), also only wheels for windows were released, so it's definitely intentional. |
|
Ah, that's a shame. It definitely worked on linux as that was the only place i tested it :X |
|
Well, cool. Guess i'll try to build it and if it works just… publish a wheel myself or something? I'm very confused right now as to what the reasoning here is. |
|
Ah, i see. The |
|
…duh i can just look at your diff. Lesson learned, time to go to bed. |
linesight
pushed a commit
to linesight/cefpython
that referenced
this pull request
Jan 28, 2024
Fixes: cztomczak#546 Had to include harfbuzz manually as newer Pango change this. See: eiskaltdcpp/eiskaltdcpp#413 https://gitlab.gnome.org/GNOME/pango/-/issues/387 Also had to add `-Wno-deprecated-declarations` to get this to compile because of the following errors that didn't seem to be coming from this code directly: warning: ‘GTimeVal’ is deprecated: Use 'GDateTime' instead warning: ‘GTypeDebugFlags’ is deprecated
cztomczak
added a commit
that referenced
this pull request
Aug 2, 2025
…sted) (#679) * py3 update for automate-git.py and automate.py * --disable-syntax-validation option at gclient has been removed from upstream * Add support for Python 3.8 and Upgrade Cython (#594) Fixes: #546 Had to include harfbuzz manually as newer Pango change this. See: eiskaltdcpp/eiskaltdcpp#413 https://gitlab.gnome.org/GNOME/pango/-/issues/387 Also had to add `-Wno-deprecated-declarations` to get this to compile because of the following errors that didn't seem to be coming from this code directly: warning: ‘GTimeVal’ is deprecated: Use 'GDateTime' instead warning: ‘GTypeDebugFlags’ is deprecated * update spotify prebuilt cef url * fix * add support for cef 123 version * Fix CefListValue "int index" params (#461). * getting partical fix from d6deaf8 * getting partical fix (part 2) from d6deaf8 * undo previous unittest change (partly) * Fix V8ContextHandler.OnContextCreated and OnContextReleased (#484). These callbacks were never called previously. Rename --no-run-examples flag to --unittests in build scripts. * add python311 support * undo previous accidental change to common.py * update misc place for py311 support * better handle MainMessageLoopExternalPump, remove some previouis test code at frame.pyx * add mainframe validation at javascript_bindings.pyx * undo unexpected change to src/compile_time_constatns.pxi * not use obsolete base/cef_ptr_util.h * add back cef_mac.h and cef_linux.h * address pull request feedback * restore previous language_level line at cython_setup.py * remove obsolete stuff * delete previously commented code * address pull request feedback * delete previously commented code * update osr_test.py to respect current event data type * delete OnPluginCrashed; add initial implementation of CanSendCookie and CanSaveCookie; restore network_cookies.py and make slight tweak to use CanSendCookie and CanSaveCookie * add back upstream cef 6312 branch's cef_types_linux.h and cef_types_mac.h * remove commented SendProcessMessage from cef_browser.pxd * one more place to use str type for uniqueFrameId * bring back SendFocusEvent in browser.pyx for backward compatibility * replace ondomread.py example using example.com, as google.com website is using complex iframe which is not good with cefpython javascript binding * remove obsolete 'ignore_certificate_errors' from cef_types.pxd --------- Co-authored-by: linesight <ted.lin0000@yahoo.com> Co-authored-by: gary <gary@byoteki.com> Co-authored-by: cztomczak <cztomczak@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #546
Had to include harfbuzz manually as newer Pango change this.
See:
eiskaltdcpp/eiskaltdcpp#413
https://gitlab.gnome.org/GNOME/pango/-/issues/387
Also had to add
-Wno-deprecated-declarationsto get this to compile becauseof the following errors that didn't seem to be coming from this code directly: