Some internal shortcut tweaks #16
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@adamichelle No stress to look at this, just tagging you here in case you get a chance to take a look! In my final internal pass of the draft and demo I thought this might be a nice way to avoid handling Mac and Windows separately and make the shortcuts a little more consistent across browsers. But I realize there may be an excellent reason you did not write it this way originally, so just shout if something looks off here! |
adamichelle
approved these changes
Mar 31, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Small proposed tweak to shortcut demo feature, to use shortcuts that hopefully do not require different handlers for Windows and Mac and work more consistently across browsers (tested on Mac and tried to research any conflicting shortcuts on Windows, but did not have Windows device to test)