Account for possible timing issues with model load #18
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lazeratops
commented
May 3, 2023
| @@ -1,8 +1,11 @@ | |||
| <template> | |||
| <div :class="chatIsOpen ? 'chat-wrapper open' : 'chat-wrapper'"> | |||
| <div> | |||
| <button class="chat" @click="handleChatClick"> | |||
| <template v-if="chatIsOpen"> | |||
| <button class="chat" @click="handleChatClick" :disabled="!model"> | |||
There was a problem hiding this comment.
Here is where the main logic is to account for the potential timing issue of model load, basically disabling chat until the model exists. Let me know if that makes sense!
lazeratops
commented
May 3, 2023
| .then((model) => { | ||
| this.model = Object.freeze(model); | ||
| }) | ||
| .catch((e) => { |
There was a problem hiding this comment.
Just adding some error logging in case something goes wrong, for easier debugging should that happen on the user's end!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR disables chat until the TensorFlow toxicity model has loaded. The chat icon remains an "X" and clicking it does nothing if the model does not yet exist.
The other (formatting) changes there are just from the automated prettier run in my IDE :)