Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug/ensure database number match when snapshotting #441

Merged

Conversation

danielealbano
Copy link
Owner

This pull request includes changes to the hashtable_mcmp_op_get_by_index function in multiple files to improve the handling of the database_number parameter. The changes ensure that the database_number is correctly passed and updated within the function calls.

Improvements to hashtable_mcmp_op_get_by_index function:

Updates to function calls:

  • src/storage/db/storage_db.c: Adjusted the call to hashtable_mcmp_op_get_by_index to pass database_number as a pointer and added a check to ensure the entry is from the correct database before deletion.
  • src/storage/db/storage_db_snapshot.c: Modified the call to hashtable_mcmp_op_get_by_index to pass database_number as a pointer.

@danielealbano danielealbano merged commit db4891a into main Dec 29, 2024
2 of 4 checks passed
@danielealbano danielealbano deleted the bug/ensure-database-number-match-when-snapshotting branch December 29, 2024 15:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant