Skip to content

Add betterproto.Enum __copy__ and __deepcopy__ implementations #566

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Mar 29, 2024

Conversation

atomicmac
Copy link
Contributor

Summary

betterproto.Enum is missing copy and deepcopy implementations, which were recently added to enum.Enum, see python/cpython#106602 This fixes the bug where betterproto messages with Enums nested within cannot be copied via copy.deepcopy.

Checklist

  • If code changes were made then they have been tested.
    • I have updated the documentation to reflect the changes.
  • This PR fixes an issue.
  • This PR adds something new (e.g. new method or parameters).
    • This change has an associated test.
  • This PR is a breaking change (e.g. methods or parameters removed/renamed)
  • This PR is not a code change (e.g. documentation, README, ...)

betterproto.Enum is missing __copy__ and __deepcopy__ implementations, which were recently added to enum.Enum, see python/cpython#106602
This fixes the bug where betterproto messages with Enums nested within cannot be copied via copy.deepcopy.
Copy link
Collaborator

@Gobot1234 Gobot1234 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this

atomicmac and others added 2 commits March 27, 2024 14:48
Co-authored-by: James Hilton-Balfe <gobot1234yt@gmail.com>
Co-authored-by: James Hilton-Balfe <gobot1234yt@gmail.com>
@Gobot1234 Gobot1234 merged commit df1ba91 into danielgtaylor:master Mar 29, 2024
22 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants