This repository was archived by the owner on Apr 8, 2025. It is now read-only.
Update emitter.dart #429
Merged
Update emitter.dart #429
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add a newline after lambdas.
1 task
Package publishing
Documentation at https://github.com/dart-lang/ecosystem/wiki/Publishing-automation. |
|
What was the motivation for this? I don't specifically disagree with the change - but I'm just now noticing the impact as I'm trying to roll it in to google3. Is it worth breaking existing golden tests for this change? |
|
Followed the backlink to dart-lang/i18n#721 (comment) I do think the change makes sense. I'll work on the golden files. |
mosuem
added a commit
to dart-lang/tools
that referenced
this pull request
Oct 25, 2024
* Update emitter.dart Add a newline after lambdas. * Rev version * Fix typo
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add a newline after lambdas.
Contribution guidelines:
dart format.Note that many Dart repos have a weekly cadence for reviewing PRs - please allow for some latency before initial review feedback.