Update namedtuple field names for linalg.qr and linalg.svd
#313
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
As the changes proposed in the PR were discussed and agreed upon during today's call (4 November 2021), will merge. If any further changes are necessary, they can be addressed in follow-up PRs. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR
linalg.qrandlinalg.svd. Previously, all namedtuple field names throughout the specification were lowercase for internal consistency. However, this was considered problematic for two reasons: (1) PyTorch is currently the only library supporting the specification in returning namedtuples and had already chosen to capitalize certain field names (e.g.,(Q,R)inlinalg.qr). Thus, requiring lowercase field names would introduce a breaking change. (2) For certain operations, capitalization allows matching mathematical naming conventions. Accordingly, this PR adopts PyTorch's naming conventions. Namely,(Q,R)for QR decomposition and(U,S,Vh)for singular value decomposition.