Skip to content

Conversation

rgommers
Copy link
Member

No description provided.

@rgommers rgommers requested a review from leofang November 16, 2023 21:27
Copy link
Contributor

@leofang leofang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, Ralf! LGTM except for one nit.

@leofang leofang added this to the v2023 milestone Nov 16, 2023
@leofang
Copy link
Contributor

leofang commented Nov 16, 2023

Q: Does it matter that we backport this?

@rgommers
Copy link
Member Author

Q: Does it matter that we backport this?

Not sure, perhaps not. I wouldn't exactly consider it a bug fix.

@rgommers
Copy link
Member Author

It looks like we're happy as is with this PR, right? I'll plan to merge it soon unless there's an objection.

@leofang
Copy link
Contributor

leofang commented Jan 12, 2024

Yup ready to go anytime!

@seberg
Copy link
Contributor

seberg commented Jan 12, 2024

Yes, thank you!

@rgommers rgommers merged commit 7a56675 into data-apis:main Jan 12, 2024
@rgommers rgommers deleted the update-dlpack-supported branch January 12, 2024 09:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants