Skip to content

TST: da.arange fails for args near 2**63 #246

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Jan 31, 2025
Merged

TST: da.arange fails for args near 2**63 #246

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
d40debd
TST: da.arange fails for args near 2**63
crusaderky Jan 30, 2025
21b7867
revert
crusaderky Jan 30, 2025
5a20d13
revert
crusaderky Jan 30, 2025
2c09310
revert
crusaderky Jan 30, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
59 changes: 4 additions & 55 deletions dask-xfails.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,25 +1,3 @@
# This fails in dask
# import dask.array as da
# a = da.array([1]).reshape((1,1))
# key = (0, slice(None, None, -1))
# a[key] = da.array([1])

# Failing hypothesis test case
#x=dask.array<zeros_like, shape=(0, 2), dtype=bool, chunksize=(0, 2), chunktype=numpy.ndarray>
#| Draw 1 (key): (slice(None, None, None), slice(None, None, None))
#| Draw 2 (value): dask.array<zeros_like, shape=(0, 2), dtype=bool, chunksize=(0, 2), chunktype=numpy.ndarray>

# Various shape mismatches e.g.
ValueError: shape mismatch: value array of shape (0, 2) could not be broadcast to indexing result of shape (0, 2)
array_api_tests/test_array_object.py::test_setitem

# Fails since bad upcast from uint8 -> int64
# MRE:
# a = da.array(0, dtype="uint8")
# b = da.array(False)
# a[b] = 0
array_api_tests/test_array_object.py::test_setitem_masking

# Various indexing errors
array_api_tests/test_array_object.py::test_getitem_masking

Expand All @@ -33,17 +11,6 @@ array_api_tests/test_data_type_functions.py::test_finfo[float32]
# (I think the test is not forcing the op to be computed?)
array_api_tests/test_creation_functions.py::test_linspace

# out.shape=(2,) but should be (1,)
array_api_tests/test_indexing_functions.py::test_take

# out=-0, but should be +0
array_api_tests/test_special_cases.py::test_binary[__pow__(x1_i is -0 and x2_i > 0 and not (x2_i.is_integer() and x2_i % 2 == 1)) -> +0]
array_api_tests/test_special_cases.py::test_iop[__ipow__(x1_i is -0 and x2_i > 0 and not (x2_i.is_integer() and x2_i % 2 == 1)) -> +0]

# output is nan but should be infinity
array_api_tests/test_special_cases.py::test_iop[__ipow__(x1_i is -infinity and x2_i > 0 and not (x2_i.is_integer() and x2_i % 2 == 1)) -> +infinity]
array_api_tests/test_special_cases.py::test_binary[__pow__(x1_i is -infinity and x2_i > 0 and not (x2_i.is_integer() and x2_i % 2 == 1)) -> +infinity]

# Array methods and attributes not already on da.Array cannot be wrapped
array_api_tests/test_has_names.py::test_has_names[array_method-__array_namespace__]
array_api_tests/test_has_names.py::test_has_names[array_method-to_device]
Expand All @@ -63,25 +30,17 @@ array_api_tests/test_set_functions.py::test_unique_values

# fails for ndim > 2
array_api_tests/test_linalg.py::test_svdvals
array_api_tests/test_linalg.py::test_cholesky

# dtype mismatch got uint64, but should be uint8, NPY_PROMOTION_STATE=weak doesn't help :(
array_api_tests/test_linalg.py::test_tensordot

# AssertionError: out.dtype=uint64, but should be uint8 [tensordot(uint8, uint8)]
array_api_tests/test_linalg.py::test_linalg_tensordot

# AssertionError: out.shape=(1,), but should be () [linalg.vector_norm(keepdims=True)]
array_api_tests/test_linalg.py::test_vector_norm

# ZeroDivisionError in dask's normalize_chunks/auto_chunks internals
array_api_tests/test_linalg.py::test_inv
array_api_tests/test_linalg.py::test_matrix_power

# did not raise error for invalid shapes
array_api_tests/test_linalg.py::test_matmul
array_api_tests/test_linalg.py::test_linalg_matmul

# Linalg - these don't exist in dask
array_api_tests/test_signatures.py::test_extension_func_signature[linalg.cross]
array_api_tests/test_signatures.py::test_extension_func_signature[linalg.det]
Expand All @@ -94,7 +53,6 @@ array_api_tests/test_linalg.py::test_cross
array_api_tests/test_linalg.py::test_det
array_api_tests/test_linalg.py::test_eigh
array_api_tests/test_linalg.py::test_eigvalsh
array_api_tests/test_linalg.py::test_matrix_norm
array_api_tests/test_linalg.py::test_matrix_rank
array_api_tests/test_linalg.py::test_pinv
array_api_tests/test_linalg.py::test_slogdet
Expand All @@ -106,14 +64,10 @@ array_api_tests/test_has_names.py::test_has_names[linalg-matrix_power]
array_api_tests/test_has_names.py::test_has_names[linalg-pinv]
array_api_tests/test_has_names.py::test_has_names[linalg-slogdet]

# missing mode kw
# https://github.com/dask/dask/issues/10388
array_api_tests/test_linalg.py::test_qr

# Constructing the input arrays fails to a weird shape error...
array_api_tests/test_linalg.py::test_solve

# missing full_matrics kw
# missing full_matrices kw
# https://github.com/dask/dask/issues/10389
# also only supports 2-d inputs
array_api_tests/test_linalg.py::test_svd
Expand All @@ -128,17 +82,12 @@ array_api_tests/test_has_names.py::test_has_names[creation-from_dlpack]
array_api_tests/test_has_names.py::test_has_names[array_method-__dlpack__]
array_api_tests/test_has_names.py::test_has_names[array_method-__dlpack_device__]

# Some cases unsupported by dask
array_api_tests/test_manipulation_functions.py::test_roll

# No mT on dask array
array_api_tests/meta/test_hypothesis_helpers.py::test_symmetric_matrices

# The test suite is incorrectly checking sums that have loss of significance
# (https://github.com/data-apis/array-api-tests/issues/168)
array_api_tests/test_statistical_functions.py::test_sum
array_api_tests/test_statistical_functions.py::test_prod
# Edge case of args near 2**63
# https://github.com/dask/dask/issues/11706
array_api_tests/test_creation_functions.py::test_arange

# 2023.12 support
array_api_tests/test_manipulation_functions.py::test_repeat
array_api_tests/test_searching_functions.py::test_searchsorted
Loading