ENH: pad: pad_width can be any sequence
#114
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pad: pad_width can be any sequencepad: pad_width can be any sequence
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a blocker to porting scipy/scipy#22308 to xpx, because jax.jit doesn't accept unhashable static arguments.
For clarity: this is just a quirk of scipy/scipy#22308. You can pass a list parameter to
xpx.padinside jax.jit; you simply can't pass it if you are callingpad = jax.jit(xpx.pad, static_argnames="pad_width"), which is not something final users will typically do.