ENH: at: add __setitem__ fancy indexing fallback
#395
+66
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lucascolley
reviewed
Aug 22, 2025
Comment on lines
+364
to
+366
| # Vectorize the operation using boolean indexing | ||
| # For non-unique indices, take the last occurrence. This requires creating | ||
| # masks for x and y that create matching shapes. |
There was a problem hiding this comment.
can you add a docs note explaining this behaviour?
Comment on lines
+357
to
+359
| # Work around lack of fancy indexing __setitem__ support in array-api-strict. | ||
| if ( | ||
| is_array_api_strict_namespace(xp) |
There was a problem hiding this comment.
what do you think about changing this PR to instead do this?
tryfancy indexing for all backends- fallback to this in the
elsecase
In general I think unknown backends should go down the same path as array-api-strict if they have to.
__setitem__ fancy indexing fallback
__setitem__ fancy indexing fallbackat: add __setitem__ fancy indexing fallback
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fancy indexing is currently not supported for
__setitem__, which blocks some PRs in scipy (scipy/scipy#23425).As discussed in data-apis/array-api#864 (comment), all frameworks of the array api already implement this feature, but not necessarily in a consistent manner for duplicate indices. It is currently not part of the standard. This PR adds a workaround for array api strict to allow fancy indexing in
xpx.at(x, ...).