ENH: Implement nan_to_num function
#398
Merged
+268
−2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lucascolley
reviewed
Aug 22, 2025
Co-authored-by: Lucas Colley <lucas.colley8@gmail.com>
Co-authored-by: Lucas Colley <lucas.colley8@gmail.com>
lucascolley
reviewed
Aug 22, 2025
nan_to_num functionnan_to_num function
|
Have addressed your comments.
|
|
ran this through sklearn and nothing immediately complained! Once we have some more tests here, lets merge it and make a release, then try to integrate it into scikit-learn 👍 |
|
I've added more tests @lucascolley. The main change is |
lucascolley
approved these changes
Aug 27, 2025
Co-authored-by: Lucas Colley <lucas.colley8@gmail.com>
Co-authored-by: Lucas Colley <lucas.colley8@gmail.com>
Co-authored-by: Lucas Colley <lucas.colley8@gmail.com>
|
let me release a 0.8.2 with this tonight and make a PR integrating it into sklearn |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #304. This is still in progress but want to see what would happen in CI.
nan_to_numis a weird function that has unexpected behaviour IMO (e.g. infinities are converted too) but feel, for now, we should keep it as downstream behaviours would expect.