Skip to content

bug: where: check condition is boolean #106

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Dec 12, 2024
Merged

bug: where: check condition is boolean #106

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion array_api_strict/_searching_functions.py
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
from __future__ import annotations

from ._array_object import Array
from ._dtypes import _result_type, _real_numeric_dtypes
from ._dtypes import _result_type, _real_numeric_dtypes, bool as _bool
from ._flags import requires_data_dependent_shapes, requires_api_version

from typing import TYPE_CHECKING
Expand Down Expand Up @@ -80,6 +80,9 @@ def where(condition: Array, x1: Array, x2: Array, /) -> Array:
"""
# Call result type here just to raise on disallowed type combinations
_result_type(x1.dtype, x2.dtype)

if condition.dtype != _bool:
raise TypeError("`condition` must be have a boolean data type")

if len({a.device for a in (condition, x1, x2)}) > 1:
raise ValueError("where inputs must all be on the same device")
Expand Down
Loading