You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Ah this is a bit awkward, because say ph.assert_dtype() will always use in_dtype both for its error messages e.g. ... [func(uint8, int16)], and sometimes use it for inferring expected. In say ph.assert_keepdimable_shape(), in_shape is indeed always used as the "expected" to assert against.
Still yeah it'd be a good idea to to review the args order a bit, and definitely write some docs. I hadn't spent too much time on documenting utils because I end up removing half the ones I write anyway, but now would be a good time to regroup.
For example, in
assert_dtype
, thein_dtype
is beforeout_dtype
array-api-tests/array_api_tests/pytest_helpers.py
Lines 83 to 90 in 511929c
assert_keepdimable_shape
thein_shape
is afterout_shape
array-api-tests/array_api_tests/pytest_helpers.py
Lines 181 to 189 in 511929c
By the way, it would be useful to have small docstrings for the various helper functions.
The text was updated successfully, but these errors were encountered: