Use first-party Hypothesis strategies from the st namespace
#19
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Sorry I didn't notice this PR for some reason. It has a few merge conflicts. Is the idea with this to make it easier to distinguish between built-in hypothesis strategies and custom ones from hypothesis_helpers? |
Yep. Meant it as a proof-of-concept to see how you feel. It's not a biggie! |
|
I'm really ambivalent either way. If this is something you feel would have helped you coming into the codebase then I am OK with it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As discussed in #18, this PR simply removes all instances of
from hypothesis.strategies import ...in favour offrom hypothesis import strategies as st, so that first-party strategies are used likest.<strategy>.If you like, I could go over the suite to aias
_array_moduleasxpand only call array module objects/methods withxp.<attribute>. Even if_array_moduleis really just a wrapper, it may add more clarity overall. Likewise I can try namespacinghypothesis_helpersandarray_helpersif you'd like.