Rename "xptests" back to "array_api_tests" #67
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
asmeurer
commented
Jan 7, 2022
| @@ -5,7 +5,7 @@ | |||
| from hypothesis import strategies as st | |||
| from hypothesis.control import assume | |||
|
|
|||
| from xptests.typing import Scalar, ScalarType, Shape | |||
| from .typing import Scalar, ScalarType, Shape | |||
There was a problem hiding this comment.
An aside: we need to avoid absolute imports like this, so that the module can easily be vendored. Maybe we should add a simple meta-test for this.
There was a problem hiding this comment.
Yep this was just an unintentional mistake
I didn't think the original name had much intention, my bad! I still very much prefer xptests. As I'm making tons of micro decisions without you anyway, I thought this was just one of them heh. I'll see about becoming more conservative (i.e. make an issue/message you) whilst not blocking other PRs I'm working, but IMO the odd revert is fine if I can't get timely reviews and want to make progress on the test suite. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See #53.
In the future, we should discuss changes like this first.