Implementing the remaining linalg tests #95
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This logic may not be correctly general but it works for every function here so far (not sure yet if it will be correct for tensordot).
We only test finite matrices because the svd (ord=2) might raise an exception with infinite values.
Start implementing tests for pinv and matrix_norm.
|
LGTM as-is, I had copied this in #96 so I can check this out rebased to master and push some fixes. Feel free to merge that PR, or just pull its contents to this branch and continue working on the remaining linalg tests. Note at some point I moved your |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Now that the ndindex changes are here, I am implementing the remaining linalg tests. I still have a few left.