DBSQLOperation Refactoring (3 of 3) #198
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ltsHelper into provider of TRowSet Signed-off-by: Levko Kravets <levko.ne@gmail.com>
…vider interface Signed-off-by: Levko Kravets <levko.ne@gmail.com>
Signed-off-by: Levko Kravets <levko.ne@gmail.com>
4e3d7a4 to
6ada0db
Compare
4 tasks
nithinkdb
reviewed
Nov 14, 2023
nithinkdb
approved these changes
Nov 14, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Continuation of #163 and #185
Modify
FetchResultsHelperand result handlers so they have unified interface and allow chaining. The idea is to form a sort of pipeline that will fetch operation results and then process it on each step. Currently it's just fetching and preparing (converting to array of rows), but later we'll add an additional step to ensure that chunk size matchesmaxRows, or steps that may convert data to different representation (or return raw data)