Add polyfills to make apache-arrow work in Node@14
#219
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Levko Kravets <levko.ne@gmail.com>
Signed-off-by: Levko Kravets <levko.ne@gmail.com>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #219 +/- ##
==========================================
+ Coverage 90.41% 90.51% +0.10%
==========================================
Files 61 62 +1
Lines 1408 1423 +15
Branches 232 238 +6
==========================================
+ Hits 1273 1288 +15
Misses 84 84
Partials 51 51 ☔ View full report in Codecov by Sentry. |
rcypher-databricks
approved these changes
Jan 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After upgrading
apache-arrowin #180 (which was needed to fix #150), this library stopped working in some Nodejs versions. Turns out thatapache-arrow@13started to massively useArray.at/TypedArray.atmethods which became available only inNode@16.6.0.Even if we forget that
apache-arrowdeclares a support forNode@12(at least in itspackage.jsonfile), we had two options:I ended up implementing own polyfill with this reasoning:
Array.at/TypedArray.atcan use same implementation);core-jswould be absolute overkill).