enable cloud fetch by default #287
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jackyhu-db
reviewed
Apr 1, 2025
lib/contracts/IDBSQLSession.ts
Outdated
| @@ -17,6 +17,7 @@ export type ExecuteStatementOptions = { | |||
| runAsync?: boolean; | |||
| maxRows?: number | bigint | Int64 | null; | |||
| useCloudFetch?: boolean; | |||
| useLZ4Compression?: boolean; | |||
There was a problem hiding this comment.
can you explain why did you introduce this useLZ4Compression option in this PR? it does not seem relevant to cloudFetch enable by default?
There was a problem hiding this comment.
Can add this in a separate PR also. Just wanted to introduce compression, as this is configurable in other drivers.
There was a problem hiding this comment.
Yes, it is better to do this in a separate PR
jackyhu-db
approved these changes
Apr 1, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Enable cloud fetch (EXTERNAL_LINKS) by default.
Testing
Benchmark tests
Benchmarking results
We get ~9% deduction in large query execution time and this gap is bound to increase with increase in result size, thus, justifying enabling cloud fetch by default.