[PECOBLR-314] add thrift protocol version handling #292
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jackyhu-db
reviewed
May 7, 2025
lib/DBSQLSession.ts
Outdated
| this.context.getLogger().log(LogLevel.debug, `Session created with id: ${this.id}`); | ||
| if (this.serverProtocolVersion) { |
There was a problem hiding this comment.
nit. can we always log even if the serverProtocolVersion is not defined, this helps us to know if it is defined or not.
jackyhu-db
reviewed
May 7, 2025
lib/DBSQLSession.ts
Outdated
| @@ -453,13 +499,17 @@ export default class DBSQLSession implements IDBSQLSession { | |||
| await this.failIfClosed(); | |||
| const driver = await this.context.getDriver(); | |||
| const clientConfig = this.context.getConfig(); | |||
|
|
|||
| // Set runAsync only if supported by protocol version | |||
| const runAsync = ProtocolVersion.supportsAsyncMetadataOperations(this.serverProtocolVersion) ? true : undefined; | |||
There was a problem hiding this comment.
nit: there are a few const runAsync = ProtocolVersion.supportsAsyncMetadataOperations(this.serverProtocolVersion) ? true : undefined; can we wrap it in a single function so that you can change the default value true and undefined in a single place.
jackyhu-db
approved these changes
May 7, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Add thrift version handling for driver support.
based on protocol features list in runtime thrift server. [Link](based on https://github.com/databricks-eng/runtime-dev/blob/3e59d727aa67cec8add4f53d326467304c62b078/sql/hive-thriftserver/if/TCLIService.thrift#L40)
Testing
unit tests
e2e test