Merge pull request #24 from aaronhuggins/master

ConradSollitt · web-flow · commit cef28d747db1 · 2025-07-29T10:31:15.000-07:00
Support emitting the end of tag name when newline and tab are used
diff --git a/js/react/jsxLoader.js b/js/react/jsxLoader.js
@@ -666,7 +666,7 @@
                         }
                     } else if (nextChar === '>') {
                         break;
-                    } else if (nextChar === ' ') {
+                    } else if (nextChar === ' ' || nextChar === '\n' || nextChar === '\t') {
                         foundName = true;
                         continue;
                     } else if (nextChar === ')' || nextChar === '&' || nextChar === '|' || nextChar === '?' || nextChar === ';') {
diff --git a/test/js/unit-testing-react.js b/test/js/unit-testing-react.js
@@ -648,6 +648,24 @@ describe('jsxLoader.js', function() {
             expect(js).to.equal('"use strict";\nReact.createElement(Test, {message: "test", value: 123}, "Hello")');
         });
 
+        it('should compile nested element with newline', function() {
+            resetIfUsingPreact();
+            var jsx = '<Test message="test" value={123}><div\ntitle="test">Hello</div></Test>';
+            var js = jsxLoader.compiler.compile(jsx);
+            console.log(js);
+            console.log(JSON.stringify(js));
+            expect(js).to.equal('"use strict";\nReact.createElement(Test, {message: "test", value: 123}, \n            React.createElement("div", {title: "test"}, "Hello"))');
+        });
+
+        it('should compile nested element with tab', function() {
+            resetIfUsingPreact();
+            var jsx = '<Test message="test" value={123}><div\ttitle="test">Hello</div></Test>';
+            var js = jsxLoader.compiler.compile(jsx);
+            console.log(js);
+            console.log(JSON.stringify(js));
+            expect(js).to.equal('"use strict";\nReact.createElement(Test, {message: "test", value: 123}, \n            React.createElement("div", {title: "test"}, "Hello"))');
+        });
+
         it('should have correct child whitespace nodes', function() {
             resetIfUsingPreact();
             var jsx = '<div><strong className={this.props.cssClass}>Test:</strong> {this.props.name} <section>Test [{this.props.name}] <span className="test">Test2</span></section></div>';
@@ -863,4 +881,4 @@ describe('<JsonData>', function() {
             expect(el.style.color).to.equal('rgb(255, 255, 255)');
         });
     });
-});
+});

Original file line number	Diff line number	Diff line change
`@@ -666,7 +666,7 @@`
`666`	`666`	`}`
`667`	`667`	`} else if (nextChar === '>') {`
`668`	`668`	`break;`
`669`		`- } else if (nextChar === ' ') {`
	`669`	`+ } else if (nextChar === ' ' \|\| nextChar === '\n' \|\| nextChar === '\t') {`
`670`	`670`	`foundName = true;`
`671`	`671`	`continue;`
`672`	`672`	`} else if (nextChar === ')' \|\| nextChar === '&' \|\| nextChar === '\|' \|\| nextChar === '?' \|\| nextChar === ';') {`