Support emitting the end of tag name when newline and tab are used #24
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…a newline or tab Simple elements compile without issue when the tag name is followed by any white space. Nested elements fail to emit the tag name when they contain newline or tab white space.
|
Thanks Aaron, I will check the code and publish this to NPM later today or this week. |
|
@ConradSollitt Thanks! I really appreciate it. I hope it was okay not to regenerate the minified files. |
|
Thanks again Aaron, I just published the new build with minified files and gave you credit on the https://github.com/dataformsjs/dataformsjs/blob/master/CHANGELOG.md |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I encountered an issue with jsxLoader where valid JSX elements with a valid tag name were skipped during compilation. I found that this only happened with nested elements, and only when followed by a newline or tab white space character. These are valid terminators for the tag name, and can easily be added by hand or by prettification of JSX code.
This pull request adds tests and support for these cases.
Tests have been ran locally and confirm both before and after the change to jsxLoader.
BEFORE:
AFTER:
