WiP ENH: yield "impossible" result record instead of exception if remote is not known #7402
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ote is not known
In this repo, where we have 'smaug' sibling only known to the top dataset
❯ giturl
http://github.com/con/opfvta-replication-2023/
if we request getting data from 'smaug'
❯ datalad get -rs smaug .
[INFO ] Ensuring presence of Dataset(/home/yoh/proj/CON/opfvta-replication-2023) to get /home/yoh/proj/CON/opfvta-replication-2023
Remote 'smaug' is not available. Command failed:
RemoteNotAvailableError: 'annex get --from=smaug -c annex.retry=3 --json --json-error-messages --json-progress'
where the problems are:
- not clear where (which submodule) the remote is not available
- we immediately fail instead of going through other submodules
- 'impossible' seems to be more appropriate than 'error'
with current patch it gets to be
❯ datalad get -rs smaug .
[INFO ] Ensuring presence of Dataset(/home/yoh/proj/CON/opfvta-replication-2023) to get /home/yoh/proj/CON/opfvta-replication-2023
get(impossible): (dataset) [Remote 'smaug' is not available in '/home/yoh/proj/CON/opfvta-replication-2023/inputs/mouse-brain-templates']
get(impossible): (dataset) [Remote 'smaug' is not available in '/home/yoh/proj/CON/opfvta-replication-2023/inputs/opfvta_bidsdata']
action summary:
get (impossible: 2)
but it feels "incorrect" in how the records is created. The comments in the
code show what I attempted to do -- the main problem is that then that datalad
doesn't show anything for me, or duplicates info if I provide exception, etc.
Please advise on how to proceed in "optimal record" way.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In this repo, where we have 'smaug' sibling only known to the top dataset
if we request getting data from 'smaug'
where the problems are:
with current patch it gets to be
but it feels "incorrect" in how the records is created. The comments in the code show what I attempted to do -- the main problem is that then that datalad doesn't show anything for me, or duplicates info if I provide exception, etc. @mih please advise on how to proceed in "optimal record" way.
TODOs