Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BF: failure to install recursively from a relative path #7479

Open
wants to merge 2 commits into
base: maint
Choose a base branch
from

Conversation

bpinsard
Copy link
Contributor

@bpinsard bpinsard commented Aug 19, 2023

Working on a fix for #7478 that looks like a more generic case of #2232 .

  • writing a test that reproduces the bug
  • write a fix

@bpinsard bpinsard force-pushed the bf/install_recursive_relpath branch from d8398ad to ff7714a Compare August 19, 2023 01:41
@bpinsard
Copy link
Contributor Author

bpinsard commented Aug 19, 2023

Not sure about the right approach to fixing that issue:

  • resolving source to absolute path for the root dataset and then submodules candidate will be absolute too, simpler option
  • trying to preserve a relative path by running git-clone while in the appropriate pwd for it to resolve.

@yarikoptic yarikoptic added semver-patch Increment the patch version when merged CHANGELOG-missing When a PR's description does not contain a changelog item, yet. labels Aug 22, 2023
@github-actions github-actions bot removed the CHANGELOG-missing When a PR's description does not contain a changelog item, yet. label Aug 22, 2023
@yarikoptic
Copy link
Member

Thank you @bpinsard for looking into this!!!
The former (keep relative) sounds like a more proper fix to do but might overall be much more involved. Looking at a sample run

(Pdb) p dest_path
'/home/yoh/.tmp/datalad_temp_test_install_recursive_relpathkh6xkzg6/dest/sub_ds'
(Pdb) p clone_urls_
['../src/sub_ds']
(Pdb) getpwd()
'/home/yoh/.tmp/datalad_temp_test_install_recursive_relpathkh6xkzg6'

suggests looking into why we are manually creating those relative leading ../ paths and now just keeping as from pwd... might look more into it later unless you beat me to it

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
semver-patch Increment the patch version when merged
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants